Add new config key RomsDirectory to Supermodel.ini - #331
Open
hywelandrews wants to merge 1 commit into
Open
Conversation
hywelandrews
changed the title
Owner
|
I need to take a look at this because I thought we had a mechanism for locating directories according to (obtuse) UNIX conventions but that might’ve been only for the config file. one nit: call it “directory”, not folder, to be consistent with the rest of the app. |
hywelandrews
force-pushed
the
new-config-rom-folder-path
branch
from
August 7, 2026 12:18
537a43e to
2506d63
Compare
hywelandrews
changed the title
Author
|
Sure, I've updated the config key and internal variables to [Rr]omsDirectory. I had a look at the OSD/FileSystem implementations when submitting the FreeBSD port, and all platforms did just have to handle config paths but I've only been able to test this on MacOSX and UNIX. Would also partially resolve #278 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rational: When using Supermodel from it's GUI roms are currently searched only in a child ROMs/ folder. This is a problem in particular when Supermodel is installed from a system package manager (homebrew, pkg, apt etc). This change allows users to configure any path to be searched when launching roms from the GUI. It is not provided as a command line option, only as a key in Supermodel.ini.
Thanks