fix: resolve decoupling capacitor identification in complex layouts#65
Open
oneAI-Automations wants to merge 1 commit intotscircuit:mainfrom
Open
fix: resolve decoupling capacitor identification in complex layouts#65oneAI-Automations wants to merge 1 commit intotscircuit:mainfrom
oneAI-Automations wants to merge 1 commit intotscircuit:mainfrom
Conversation
This PR fixes the IdentifyDecouplingCapsSolver by implementing fuzzy net matching (VCC/GND/VDD) and replacing brittle string-splitting logic with robust chipPinMap lookups. Verification: Successfully passed test suite with the following results: Capacitor C1 correctly mapped to Chip U1. Fixed TypeError caused by missing constructor property in input.
|
@oneAI-Automations is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Attached is the local test result showing the solver successfully identifying the decoupling group (C1 -> U1) and passing the fix suite. 
|
Author
|
Fixes #[Issue Number] |
Author
|
/claim |
Author
|
/claim #15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the IdentifyDecouplingCapsSolver by implementing fuzzy net matching (VCC/GND/VDD) and replacing brittle string-splitting logic with robust chipPinMap lookups.
Verification: Successfully passed test suite with the following results:
Capacitor C1 correctly mapped to Chip U1.
Fixed TypeError caused by missing constructor property in input.