Skip to content

Rename SubcircuitGroupProps manufacturing DRC fields to updated camelCase names#641

Merged
imrishabh18 merged 1 commit intomainfrom
codex/rename-props-in-subcircuitgroupprops
Apr 23, 2026
Merged

Rename SubcircuitGroupProps manufacturing DRC fields to updated camelCase names#641
imrishabh18 merged 1 commit intomainfrom
codex/rename-props-in-subcircuitgroupprops

Conversation

@imrishabh18
Copy link
Copy Markdown
Member

Motivation

  • The manufacturing DRC-related prop names on SubcircuitGroupProps were updated and needed to be reflected in the codebase using consistent camelCase naming.
  • Runtime validation and generated documentation must match the new property names to avoid consumer/CI breakage.

Description

  • Renamed the DRC-related props on the SubcircuitGroupProps TypeScript interface in lib/components/group.ts to minViaHoleEdgeToViaHoleEdgeClearance, minPlatedHoleDrillEdgeToDrillEdgeClearance, minTraceToPadEdgeClearance, and minPadEdgeToPadEdgeClearance while keeping other existing fields unchanged.
  • Updated the subcircuitGroupProps Zod schema in lib/components/group.ts to use the same renamed keys for runtime validation.
  • Regenerated the derived documentation files so generated artifacts reflect the change, updating generated/COMPONENT_TYPES.md and generated/PROPS_OVERVIEW.md accordingly.

Testing

  • Ran the required generation scripts: bun scripts/generate-component-types.ts, bun scripts/generate-manual-edits-docs.ts, bun scripts/generate-readme-docs.ts, and bun scripts/generate-props-overview.ts, which completed successfully.
  • Ran the focused test suite bun test tests/group.test.ts, which passed (16 tests, 0 failures).

Codex Task

@imrishabh18 imrishabh18 merged commit e7b8879 into main Apr 23, 2026
4 checks passed
@imrishabh18 imrishabh18 deleted the codex/rename-props-in-subcircuitgroupprops branch April 23, 2026 17:35
@tscircuitbot
Copy link
Copy Markdown
Contributor


Thank you for your contribution! 🎉

PR Rating:
Impact: Tiny

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants