Repository navigation
Ignore gap-fill regions narrower than the trace width - #161
Closed
ShiboSoftwareDev wants to merge 1 commit into
Closed
ShiboSoftwareDev wants to merge 1 commit into
ShiboSoftwareDev wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
Closing after end-to-end validation: deleting sub-trace-width gap regions disconnects PMP22650 port-point pathing. The region is a topology bridge and must be preserved; the root fix belongs in bounded downstream subdivision. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Gap filling creates routing regions narrower than
minTraceWidth. PMP22650 gets a 5.05994 × 0.00276 mm region that no legal 0.1 mm trace can use; downstream it becomes 306 mesh nodes.Fix
Pass
minTraceWidthinto gap filling and skip generated regions whose width or height is smaller. Existing legal regions are unchanged. SVG snapshots remove the same unroutable slivers.Stacked on #160.
Tests
bun test— 105 pass, 1 skip, 0 failbun run buildbun run format:check