Repository navigation
Respect board-edge clearance for bounds-only boards - #176
Open
1932819331hy-debug wants to merge 2 commits into
Open
1932819331hy-debug wants to merge 2 commits into
1932819331hy-debug wants to merge 2 commits into
Conversation
|
Someone is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For a rectangular board described only by
bounds,minBoardEdgeClearancewas ignored:Derive a local rectangular outline for positive bounds-only clearance, reuse the existing board-void calculation, and include those masks in the shared grid obstacle index. This makes initial grid generation and gap filling honor the same boundary as an equivalent explicit rectangle. Physical input bounds and supplied outlines are preserved.
Evidence
After: all six pass, including translated bounds, three layers, one/three permitted gap-fill passes, a near-edge obstacle and omitted/zero/negative-clearance controls. The focused clearance/bounds/outline suite passes 20 tests.
Validation used Bun 1.3.1 with genuine declared-compatible registry dependencies in an isolated local environment.
Merge Danger
Door: Two-way; a normal revert restores the previous behavior.
Blast Radius: Routing.
Positive clearance now excludes bounds-only edge strips on all board layers. Omitted, zero and negative clearance preserve existing bounds-only behavior. Clearance that leaves no usable mesh (including an interior below the configured minimum node size) still reaches the existing empty-grid failure also reproducible with an explicit outline, tracked separately in #173.