feat: merge same-net trace lines that are close together#192
Open
tarai-dl wants to merge 1 commit intotscircuit:mainfrom
Open
feat: merge same-net trace lines that are close together#192tarai-dl wants to merge 1 commit intotscircuit:mainfrom
tarai-dl wants to merge 1 commit intotscircuit:mainfrom
Conversation
Adds a new solver that finds traces belonging to the same net with parallel segments that are close together (at the same Y for horizontal segments or the same X for vertical segments) and merges them by aligning their coordinates. This solves the issue where same-net trace lines running close together would appear as separate parallel lines instead of being merged into one. Changes: - Added SameNetTraceMergerSolver with configurable merge threshold (default 0.15) - Integrated into the pipeline after TraceCleanupSolver - Added comprehensive tests for horizontal/vertical merging, different nets, and edge cases Fixes tscircuit#34
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
SameNetTraceMergerSolverthat merges same-net trace lines that are close together (at the same Y for horizontal segments or the same X for vertical segments).Changes
SameNetTraceMergerSolverinlib/solvers/SameNetTraceMergerSolver/TraceCleanupSolverHow it works
The solver:
globalConnNetId(same net)Testing
All existing tests pass plus 5 new tests:
Fixes #34