Merge same-net trace lines that are close together (snap to same X/Y)#196
Open
CyberSculptor96 wants to merge 19 commits intotscircuit:mainfrom
Open
Merge same-net trace lines that are close together (snap to same X/Y)#196CyberSculptor96 wants to merge 19 commits intotscircuit:mainfrom
CyberSculptor96 wants to merge 19 commits intotscircuit:mainfrom
Conversation
… close together. Finds parallel segments (same X or same Y within a threshold) belonging to the same net and snaps them to a shared coordinate, then simplifies the resulting paths.
…re close but not aligned, and verifies they get merged to the same coordinate after the cleanup solver runs.
…er balancing L-shapes. This step calls mergeSameNetTraces for groups of traces sharing the same globalConnNetId, merging parallel segments that are within a configurable distance threshold.
…th segments that result from merging (segments where start and end are essentially the same point after snapping).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… add mergeSameNetTraces step
Author
|
Hi! All CI checks are now passing ✅
This PR implements the fix for #34 by adding a
Happy to address any review feedback. Let me know if anything needs adjustment! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new trace cleanup step that merges same-net trace segments running in parallel when they are within a small distance threshold. Parallel horizontal segments get snapped to the same Y coordinate, and parallel vertical segments get snapped to the same X coordinate.
Changes
mergeSameNetTraces.tswith logic to detect and merge close parallel same-net segmentsTraceCleanupSolverpipeline with amerging_same_net_tracesstep after Z-shape balancingsimplifyPathto handle degenerate segments from coordinate snappingCloses #34