fix: skip wire routing for net-label-only nets (issue #79)#198
Open
Wong789 wants to merge 11 commits intotscircuit:mainfrom
Open
fix: skip wire routing for net-label-only nets (issue #79)#198Wong789 wants to merge 11 commits intotscircuit:mainfrom
Wong789 wants to merge 11 commits intotscircuit:mainfrom
Conversation
Skip routing nets that have no direct wire connections and only have net label orientations. NetLabelPlacementSolver will place the net labels instead, fixing spurious extra trace lines. Fixes tscircuit#79
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rushabhcodes
requested changes
Apr 18, 2026
rushabhcodes
left a comment
rushabhcodes
left a comment
There was a problem hiding this comment.
tests are failing, also add proof
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Issue #79: Fix extra net label in repro61, or remove trace
Problem
Nets handled exclusively via net label connections (no direct wire connections) were getting spurious extra trace lines. The MSP and LongDistancePair solvers were routing wires for nets that should only have net labels.
Solution
Filter nets from the routing queue if they have no direct wire connections AND have net label orientations configured. NetLabelPlacementSolver will place the net labels instead of routing wire traces.
Changes
lib/solvers/MspConnectionPairSolver/MspConnectionPairSolver.ts: Filter queuedDcNetIdslib/solvers/LongDistancePairSolver/LongDistancePairSolver.ts: Filter queuedCandidatePairsTesting
Validated against issue #79 test case.
Fixes #79
/claim #79