fix: remove redundant second pass in simplifyPath (#78)#202
Open
BossChaos wants to merge 1 commit intotscircuit:mainfrom
Open
fix: remove redundant second pass in simplifyPath (#78)#202BossChaos wants to merge 1 commit intotscircuit:mainfrom
BossChaos wants to merge 1 commit intotscircuit:mainfrom
Conversation
- The simplifyPath function had two identical passes that both removed collinear points - The second pass (lines 25-38) was redundant and could potentially introduce extra trace lines - Removed the duplicate loop, keeping only the first simplification pass Fixes tscircuit#78
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #78 - removes extra trace lines in post-processing step.
Root Cause
The
simplifyPathfunction inlib/solvers/TraceCleanupSolver/simplifyPath.tshad two identical passes that both remove collinear points:The second pass was completely redundant and could potentially introduce visual artifacts in the trace rendering.
Changes
Testing
The existing test suite should pass as this is a pure optimization that produces the same output for valid inputs.