add debug labels to NetLabelPlacementSolver#208
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
imrishabh18
reviewed
Apr 22, 2026
seveibar
changed the title
seveibar
requested changes
Apr 22, 2026
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
Careful w/ AI PR titles, your original title had "chore:", these designations are often wrong. We don't care about commit names or branch names but we DO care about PR titles a lot because they go into a changelog and attribution system that is scanned by AI
The main reason for my request for changes is you're violating "variable transparency"- make sure the labels reflect the actual data without renaming anything, this clarifies things greatly see my comments for examples...
seveibar
reviewed
Apr 22, 2026
seveibar
reviewed
Apr 22, 2026
seveibar
reviewed
Apr 22, 2026
seveibar
reviewed
Apr 22, 2026
seveibar
reviewed
Apr 22, 2026
seveibar
reviewed
Apr 22, 2026
seveibar
reviewed
Apr 22, 2026
seveibar
reviewed
Apr 22, 2026
seveibar
reviewed
Apr 22, 2026
Sang-it
changed the title
seveibar
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.