feat: highlight all same-net traces on hover#173
Open
LuSrodri wants to merge 3 commits intotscircuit:mainfrom
Open
feat: highlight all same-net traces on hover#173LuSrodri wants to merge 3 commits intotscircuit:mainfrom
LuSrodri wants to merge 3 commits intotscircuit:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When hovering over any schematic trace, all traces that belong to the same electrical net are now highlighted in orange (
#f5a623).Implementation
New file:
lib/hooks/useSchematicTraceHoverHighlight.tscircuitJsonusing union-find oversource_trace.connected_source_port_idsmouseover/mouseoutevent listeners to the SVG div[data-schematic-trace-id], looks up the hovered trace's net group and paints all group members with the highlight colormouseoutcircuitJsonKeychangeModified:
lib/components/SchematicViewer.tsxuseSchematicTraceHoverHighlight({ svgDivRef, circuitJson, circuitJsonKey })useChangeSchematicTracesForMovedComponents,useSchematicGroupsOverlay)How it works
The hook uses the same DOM query pattern as
useChangeSchematicTracesForMovedComponents([data-schematic-trace-id]selectors), so it is compatible with any circuit-to-svg output version that emits those attributes./claim #1130