Decouple partial-rip cap from threshold ramp - #160
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Benchmark This PRRun benchmarks by commenting on this PR: Everything after Examples:
Any PR whose title contains |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
RIP_THRESHOLD_RAMP_ATTEMPTSas the denominator for the congestion-threshold rampPARTIAL_RIP_MAX_ATTEMPTSonly to cap how many completed rerip rounds runWhy
The partial-rip attempt cap previously compressed the threshold ramp whenever it was lower than
RIP_THRESHOLD_RAMP_ATTEMPTS. That coupled a runtime budget to routing policy: reducing the number of rounds changed which regions were ripped and could change the selected topology.Keeping the ramp schedule independent lets integrations stop once their observed candidate frontier has converged without perturbing earlier candidates or their region costs.
Validation
bun test tests/outside-in-partial-rip-tiny-hypergraph-solver.test.ts— 10 passedbun run typecheck— passedgit diff --check— passedbun test— 108 passed; 3 visualization suites could not load the localsharp-darwin-arm64v8native module (unchanged environment issue)