Repository navigation
Fix/cli ts morph common pnpm - #618
Conversation
… errors to the stats API - import SyntaxKind from ts-morph instead of the undeclared @ts-morph/common, which broke `pnpm dlx tsed init` (isolated node_modules) - declare the missing ts-morph dependencies in cli-testing, cli-plugin-mongoose and cli-plugin-typegraphql - report errors raised before the injector exists (failed import, plugin loading) to the stats API - send default values for the fields required by the stats API so failed init reports are no longer rejected Closes #615 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- replace the `workspace:*` peer ranges published as-is on npm by `>=7.0.0` for @tsed/cli and @tsed/cli-core - stop declaring the same Ts.ED packages in both dependencies and peerDependencies with diverging ranges - move the Ts.ED singletons (core, di, hooks, schema, logger) to peerDependencies >=8.38.0 in cli-core, cli-prompts, cli-tasks and cli-mcp - declare @tsed/cli, @tsed/cli-core and @tsed/di as peers of every plugin - declare the runtime imports missing from cli-testing, cli-plugin-typegraphql, cli-plugin-passport and the generate plugins - replace the unused @tsed/platform-http peer of the generate plugins by optional platform peers - alias @tsed/hooks and @tsed/logger to the CLI copies when loading plugins - drop the redundant `optional: false` peerDependenciesMeta entries Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9fe90745ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| tsed_version: UNKNOWN, | ||
| platform: UNKNOWN, | ||
| convention: UNKNOWN, | ||
| package_manager: getPackageManager(), |
There was a problem hiding this comment.
When init fails before the injector exists, this direct payload omits the required style field, even though InitStatPayload requires it and the normal CliStats.sendInit() path always supplies it. The stats API rejects incomplete payloads, so these boot failures—the scenario this new reporter is intended to capture—will not be recorded; include a non-empty fallback such as "unknown" and assert it in the new test.
Useful? React with 👍 / 👎.
|
🎉 This PR is included in version 7.8.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
1 participant
No description provided.