[scripts] add non-matching find-msg mode#1726
Draft
coyaSONG wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
match|not-matchmode tofind-msgIS NOTsemantics so a message without the focused field also counts as non-matchingThis lets users move to the next or previous message whose chosen field differs from the focused message, while existing invocations continue to work unchanged.
Closes #1666
Validation
not-matchwas ignored and selected the next matching line (995)not-matchselected line662not-matchselected line660matchboth selected line995find-msgcompatibility sequence remained995,661,661,994bash -n test/test_sql_indexes.shgit diff --checkA full native
make checkwas not run locally because this checkout does not have lnav's complete native dependency/vcpkg toolchain; the focused script behavior was exercised through the official binary, and upstream CI remains the full build gate.AI assistance
OpenAI Codex assisted with implementation and validation. No human review is claimed.