Repository navigation
Settings window: set the titlebar icon - #17
Merged
Merged
Conversation
WinUI shows nothing left of the title until AppWindow.SetIcon is called, and no window set one — the Settings window opened with a blank in the corner that every other titled Windows app fills with its icon. Point SetIcon at the running exe: rivet build embeds the app icon at resource ID 1 (RT_GROUP_ICON #1), so the staged tree and the installed build resolve it identically without staging a separate .ico file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-reported on the Windows leg: the Settings window opens with a blank in the titlebar where every other titled Windows app shows its icon.
Root cause
WinUI renders nothing left of the window title until
AppWindow.SetIconis called, and no Fulcrum window ever called it. The launcher doesn't need one (it is borderless and hidden from switchers since #16), but the Settings window is a document-style titled surface — the blank corner read as a bug because it is one.Fix
AppWindow.SetIconpointed at the running exe (GetModuleFileNameW): rivet build embeds the app icon at resource ID 1 (RT_GROUP_ICON #1 — landed with #15), so the staged tree and the installed build resolve the same icon without staging a separate.icofile.Verified on this machine
raco rivet buildclean (0 errors)