You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
follow-ups from the RVT1 device gateway review (#305) #312
Four minor findings from the pre-merge review of #305, none blocking:
Hello read has no deadline — RivetDeviceAppleRVT1Client.start() reads the post-RVD1 hello without a bounded budget, so a silent authenticated peer holds the session indefinitely. Mirror the RVD1 30-second post-TLS deadline policy.
Deny surface half-pinned — DeviceGatewayTests pins invokeRPC("\$state/get") but not \$state/set through the ordinary route, nor an end-to-end gateway $state/set denial.
Wedged backend shrinks capacity — cancelledIDs/requestTasks entries are never swept if a backend dispatch task ignores cancellation; bounded by the 64-request cap but permanently reduces effective capacity for that connection.
Handshake error typing — pre-hello failures rethrow raw channel/protocol errors instead of the typed RivetDeviceAppleRVT1ClientError surface.
Activity
feat(apple): connect typed RVT1 client to scoped device gateway (#305)