Repository navigation
Pass the update-payload keyword only when payloads are configured - #268
Merged
Merged
Conversation
The release smoke on CI hit a stale compiled release.rkt that did not accept the new keyword: files committed in the same second can slip past raco make's mtime freshness check. Calling the old signature for the default flow keeps mixed-version compilations working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #267: the Linux release smoke called the new release-project! keyword against a stale compiled release.rkt (same-second mtime defeats raco make's freshness check), so the default flow now uses the old signature when no payloads are configured.