Repository navigation
feat(android): add Keystore-backed device pairing credential storage - #308
Merged
Merged
Conversation
…nomy A corrupted or removed AndroidKeyStore threw raw IOException or GeneralSecurityException out of loadPairing/savePairingCredential while the rest of the store reports IllegalStateException, so callers had to know Keystore internals to fail closed. Key access now translates those into the same unavailable-key error, and the class doc states the real invariant: one key per application ID, per-device binding via AES-GCM AAD. The plan's M3 handoff records the storage evidence it was missing.
turinglambdaai
marked this pull request as ready for review
October 22, 2026 15:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
AndroidKeystorePairingStorein the SDK-backed Android adapter implements the RVD1 credential persistence gate, plus load/remove/list without exposing credential data in the list.commit(), and corrupted or backup-restored ciphertext fails closed.Security/release boundaries
Product must exclude the private preference file from backup, handle device-side explicit pairing consent, provide UI and revocation; this PR does not claim hardware-backed key availability on every model, mobile release readiness, or real-device pairing evidence.
Validation
Full CI is required prior to merge; this PR is a draft until tests complete. Independent of #306 and #307. Base
1248a90cdf347edfb44731ff7c8f69c94df96d59.