Repository navigation
fix(macos): center the drag arrow between DMG installer icons - #28
Merged
Merged
Conversation
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The DMG's drag hint is currently an upward-curving arrow. At Finder's fixed icon placements, the arc looks too high and its arrowhead does not line up naturally with the visual drag direction.
Changes
assets/dmg-background.png, not the SVG. Before macOS release and packaged acceptance, render the updated SVG to that PNG usinglibrsvg, and fail early on the wrong PNG dimensions. This also prevents stale PNGs from silently shipping on later artwork changes.Validation
librsvg).Does not change project slug, bundle name or runtime behavior. No automatic merge.