Repository navigation
polish: feedback entry points on every surface (Linux About link, README, site) - #56
Merged
Merged
Conversation
The Linux About dialog defined aboutReportIssue in both i18n tables but never rendered it — GtkAboutDialog cannot hold a second link, so Linux was the only host whose About page lacked the issue-tracker entry. Rebuild it on a plain GtkDialog with the family layout (tagline, license, website + Report-an-Issue link buttons) matching macOS and Windows. Point README (en/zh) and the product-site footer at the same tracker; Taskly is offline-first with no telemetry, so issues are the channel. Fixes #55.
PRODUCT-SPEC §8 promises the About dialog shows the © 2026 Taskly Team line and both link buttons on every host. Windows and Linux lacked the © line, and the spec's Linux note still described GtkAboutDialog — the one widget that cannot carry the issue link the same paragraph requires. - Windows: prepend the © TextBlock to the About ContentDialog panel. - Linux: prepend the © label to the plainGtkDialog from the previous commit. - PRODUCT-SPEC §8 now describes the actual implementation (plain GtkDialog on Linux) and keeps the field list canonical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55.
What
show_about_dialog()rebuilt on a plain GtkDialog — same family layout as macOS/Windows (tagline, license, website + Report an Issue link buttons). Previously theaboutReportIssuestring existed in both i18n tables but nothing rendered it;GtkAboutDialogcannot carry a second link. GtkLinkButton opens the URI via the system browser natively.问题反馈 / Feedbacklink (+footer.feedbackin the zh/en dicts).Verification
sync-i18n --checkunaffected.raco rivet acceptance --json— all 5 suites pass fresh at the base commit (first run had a one-off native quick-add input timeout; clean retry passed 5/5).Part of the v0.2.4 release prep; rides before the version PR.