Skip to content

fix: complete the next_blocked_agent integration (test build + config reference) - #2

Open
nierz wants to merge 8 commits into
tvaintrob:masterfrom
nierz:fix/test-next-blocked-agent
Open

nierz wants to merge 8 commits into
tvaintrob:masterfrom
nierz:fix/test-next-blocked-agent

Conversation

@nierz

@nierz nierz commented Aug 10, 2026

Copy link
Copy Markdown

Two follow-ups to b79ccf5, both of which currently fail on master.

1. The test suite cannot compile

The test-only execute_navigate_action_in_context match in src/app/input/navigate.rs was not updated when NextBlockedAgent was added:

error[E0004]: non-exhaustive patterns: `navigate::NavigateAction::NextBlockedAgent` not covered
    --> src/app/input/navigate.rs:1607:11

This blocks the entire suite — no tests can run at all, on any branch.

Adds the missing arm. Focusing the next blocked agent resolves agent panel entries that only the App-level dispatch can reach, so this test-only path simply leaves navigate mode, the same way the other agent actions degrade in this context.

2. The config reference is out of sync

scripts/config_reference_check.py also fails on master:

error: config reference is out of sync with src/config
- keys.next_blocked_agent: in src/config but missing from docs/next/website/src/data/config-reference.json

Adds the missing keys.next_blocked_agent row.

Verification

  • cargo build --release — clean
  • cargo test --release --bin herdr -- --test-threads=12638 passed, 0 failed
  • python3 scripts/config_reference_check.py — passes

One unrelated flake exists under parallel runs (pane_graphics_stream::inactive_owner_cancels_idle_stream_and_dispatches_close, a timing/AddrInUse issue); it passes consistently in isolation and serially.

🤖 Generated with Claude Code

tvaintrob and others added 7 commits July 16, 2026 13:30
Add ui.tab_bar_position, ui.show_clock, and ui.prefix_hint to the
versioned config reference so it stays in sync with the config model.
…ts (tvaintrob#1)

Adds a new configurable keybinding `next_blocked_agent` that focuses the
next agent in blocked state, wrapping around when reaching the end.
This allows quickly jumping to agents that need human input without
cycling through idle/working agents.

Configuration (in config.toml):
  [keys]
  next_blocked_agent = "prefix+shift+n"

Co-authored-by: tamir altshuler <tamir@tamirs-MacBook-Pro.local>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The test-only `execute_navigate_action_in_context` match was not updated
when `NextBlockedAgent` was added, so the crate fails to compile under
`cfg(test)` with E0004 and no tests can run.

Add the missing arm. Focusing the next blocked agent needs agent panel
entries that only the App-level dispatch can resolve, so this path just
leaves navigate mode, mirroring how the other agent actions degrade here.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
`scripts/config_reference_check.py` fails on master because the binding
exists in src/config but was never added to the reference data.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@nierz nierz changed the title fix(test): cover NextBlockedAgent in navigate action match fix: complete the next_blocked_agent integration (test build + config reference) Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants