fix [#31]: Add explicit 'file:' URL handling and update documentation#32
Merged
tvandinther merged 2 commits intoAug 30, 2025
Conversation
Owner
|
Thanks for making these changes! I will give a proper review of the tests and documentation changes over the weekend. |
tvandinther
requested changes
Aug 30, 2025
Owner
tvandinther
left a comment
tvandinther
left a comment
There was a problem hiding this comment.
I've fixed the pipeline on master. Could you please rebase your changes so we can get a valid pipeline run?
- Added explicit handling for URLs prefixed with 'file:' in DatabaseWrapper. - Updated DatabaseClientOptions.Url documentation with examples for: - In-memory database - Local file database - Connection string
hypnotic-frog
force-pushed
the
fix/issue_31-add-file-url-case-and-docs
branch
from
bea9558 to
38fe904
Compare
tvandinther
approved these changes
Aug 30, 2025
Owner
|
Thanks again for your contribution. Before I can cut a release I need to renew the Nuget tokens. Feel free to open an issue requesting a new release if you need it and it doesn't happen soon but I intend to address it in the next few days. Edit: It is done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces explicit support for URLs prefixed with 'file:' in the DatabaseWrapper, ensuring that local file databases are correctly recognized instead of relying on the default fallback.
Additionally, the documentation for DatabaseClientOptions.Url and README has been updated to clearly show how to open different types of databases:
No breaking changes are introduced, and existing behavior for memory and remote URLs remains intact.
Closes issue #31.