Add --git-extended-diffs option to restore 0.4.3 compatibility#164
Merged
Add --git-extended-diffs option to restore 0.4.3 compatibility#164
Conversation
Version 0.4.4 introduced support for Git diffs without content hunks (renames, copies, mode-only changes, binary files), which changed file numbering behavior and broke compatibility with 0.4.3. This caused scripts using -N/-F options to fail. Add --git-extended-diffs=exclude|include option to control this behavior. In 0.4.x, the default is 'exclude' to restore 0.4.3 compatibility. Users wanting the 0.4.4 behavior can use 'include'. Implementation: - Add git_extended_diffs_mode enum with EXCLUDE/INCLUDE values - Skip extended diffs when in exclude mode to restore 0.4.3 behavior - Add comprehensive test coverage in git-extended-diffs-exclude/ - Update all existing git-* tests to use --git-extended-diffs=include - Update documentation for filterdiff, lsdiff, grepdiff, patchview - Update NEWS to explain the reversion and new option The default will change to 'include' in version 0.5.0 for modern Git workflow support. Addresses GitHub issue #157. Assisted-by: Claude Code
twaugh
force-pushed
the
git-extended-diffs-option
branch
from
8d7c479 to
5ac07e2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.4.x #164 +/- ##
=======================================
Coverage 83.60% 83.60%
=======================================
Files 5 5
Lines 4196 4215 +19
Branches 1001 1006 +5
=======================================
+ Hits 3508 3524 +16
- Misses 688 691 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Extends git-extended-diffs-exclude test to cover three previously uncovered code paths: GIT_DIFF_NORMAL handling in exclude mode, goto eof path for extended diffs at end of file, and invalid argument error handling. Assisted-by: Claude Code
Contributor
|
I don’t see any issue, but I won’t have time to analyze it further over the next few days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed: #157