Open
Conversation
L98293
reviewed
Apr 16, 2026
L98293
reviewed
Apr 16, 2026
Contributor
There was a problem hiding this comment.
build 패키지는 삭제 바랍니다.
merge 충돌 원인 중 하나 입니다.
| public class LoginController { | ||
|
|
||
| @GetMapping("/api/oauth/signin/success") | ||
| public Map<String,Object> getProfile(@AuthenticationPrincipal OAuth2User oAuth2User) { |
Contributor
There was a problem hiding this comment.
반환 타입이 따로 Response를 만들어서 하는게 아니라 Map을 반환하는 이유가 궁금합니다.
| "/api/auth/signout", | ||
| "/api/auth/password/reset", | ||
| "/oauth2/**", | ||
| "/login/**", |
Contributor
There was a problem hiding this comment.
/** 사용하지 마세요.
모든 엔드포인트 하나하나 명시해주시길 바랍니다.
또한 HttpMethod.POST, HttpMethod.GET등을 활용해 요청을 확실하게 명시해주시길 바랍니다.
abcb-s
reviewed
Apr 22, 2026
| @@ -36,7 +36,12 @@ public class Member { | |||
| public void setPassword(String password) { | |||
Contributor
There was a problem hiding this comment.
여기서는 줄바꿈 없고 밑에 1개는 줄바꿈 있고 또 그 밑에는 없는데 컨벤션에 맞게 통일해 주세요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업내용
관련 이슈
#4
Jira 기능 링크(선택)
https://team-23d.atlassian.net/browse/KAN-2
확인사항