Skip to content

Optionally write resolution manifests#78

Draft
Duhemm wants to merge 1 commit intotwitter:mainfrom
Duhemm:manifest
Draft

Optionally write resolution manifests#78
Duhemm wants to merge 1 commit intotwitter:mainfrom
Duhemm:manifest

Conversation

@Duhemm
Copy link
Copy Markdown
Contributor

@Duhemm Duhemm commented May 7, 2021

The resolution manifests include information about all the transitive
dependencies that are included as part of the resolution for every third
party target.

The resolution manifests are written if and only if --manifests-root
is passed to multiversion. This path is used as the root under which the
manifests should be written. One manifest is written per resolved
target.

Given a manifest root set to foo/bar, and a target fizz/buzz:quux,
the manifest will be written in foo/bar/fizz/buzz/bazel-deps-quux.txt.

The resolution manifests include information about all the transitive
dependencies that are included as part of the resolution for every third
party target.

The resolution manifests are written if and only if `--manifests-root`
is passed to multiversion. This path is used as the root under which the
manifests should be written. One manifest is written per resolved
target.

Given a manifest root set to `foo/bar`, and a target `fizz/buzz:quux`,
the manifest will be written in `foo/bar/fizz/buzz/bazel-deps-quux.txt`.
} yield index.reconciledDependency(dependency).repr
val output = dependencies.distinct.sorted.mkString(System.lineSeparator())
Files.createDirectories(manifest.getParent())
Files.write(manifest, output.getBytes)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs a header showing this is a generated file.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In phabricator the @generated header collapses the file by default in the phab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants