small improvements to comment and logging messages for _filter_misleading_notes#206
Open
presnick wants to merge 2 commits intotwitter:mainfrom
Open
small improvements to comment and logging messages for _filter_misleading_notes#206presnick wants to merge 2 commits intotwitter:mainfrom
presnick wants to merge 2 commits intotwitter:mainfrom
Conversation
…match code about which timestamp)
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cutoff time was c.notMisleadingUILaunchTime, not the TombstoneLaunchTime.
Other changes to docstring just to make it easier to follow. Please check my understanding, that before c.notMisleadingUILaunchTime, you didn't assess helpfulness of notes that didn't assert the tweet was misleading, but after that you did.
Added a line to the logging to show the quantity for the last group of ratings you're keeping.