SMS and Account Self-Service API proofreading#104
SMS and Account Self-Service API proofreading#104radekholy24 wants to merge 24 commits intotyntec:masterfrom
Conversation
radekholy24
changed the title
sms/v1/openapi.yaml
Outdated
| originMNC: | ||
| type: string | ||
| type: number |
There was a problem hiding this comment.
Could not test it. Is this correct?
There was a problem hiding this comment.
Nope according to the code, those values are indeed strings. So the example must have double quotes and the type should remain string
|
@0xdeadbee, this is now ready to be reviewed. Can you please take a look? |
alextoulps
left a comment
alextoulps
left a comment
There was a problem hiding this comment.
Couple of reverts needed. Other than that really nice, thanks!
sms/v1/openapi.yaml
Outdated
| originMNC: | ||
| type: string | ||
| type: number |
There was a problem hiding this comment.
Nope according to the code, those values are indeed strings. So the example must have double quotes and the type should remain string
radekholy24
force-pushed
the
proofreading-sms
branch
3 times, most recently
from
ccf262c to
1594d0c
Compare
radekholy24
force-pushed
the
proofreading-sms
branch
from
1594d0c to
c14018d
Compare
| post: | ||
| tags: | ||
| - BYON Contact Service | ||
| summary: Create a contact | ||
| description: Creates a new contact. | ||
| security: | ||
| - ApiKeyHeader: [] | ||
| operationId: createContactUsingPOST | ||
| requestBody: | ||
| $ref: "#/components/requestBodies/ContactEntity" |
There was a problem hiding this comment.
@0xdeadbee, one last thing. It confuses me that the request to create a contact requires a comma-separated list but the content type is JSON. Shouldn't that be the text/csv content type?
2 participants
I have been assigned a task to proofread the API Reference. Alex has suggested to me to create a pull request for all my findings.