Fix appearance of sponsors#667
Merged
Merged
Conversation
- add width and height to logos so they appear in Firefix - add wrap and spacing so layout behaves better on medium sized displays. I assume this is what the empty columns I removed were trying to do?
jducoeur
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that I only can see 2 sponsors in Firefox on Mac. A quick googling indicates that this happens when an SVG is missing a width and height. I added attributes matching the view boxes, and now they show up!
While meddling with that, I saw the logos go off the edge of the screen at medium resolutions before the dsiplay is narrow enough that they become one column. I changed the flexbox settings to let it wrap
Was the intention to avoid multiple rows? If so, I guess we'd have to turn it into a column sooner instead.
Firefox Issue
Before (Firefox):
After (Firefox):
After (Safari):
Small Display Issue
Before:
After:
