Repository navigation
fix: avoid failover on client-local HTTP errors - #153
Merged
tharropoulos merged 2 commits intoOct 7, 2026
Merged
tharropoulos merged 2 commits into
tharropoulos merged 2 commits into
Conversation
This was referenced Oct 7, 2026
Collaborator
|
thanks for this! i pushed one commit on top with extra tests: the same check for all four client-local errors (not just |
tharropoulos
force-pushed
the
fix/client-errors-do-not-failover
branch
from
October 7, 2026 10:11
e656c44 to
a9be046
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #143 by keeping client-local
httpxfailures out of the node-health retry path. Pool exhaustion, local protocol errors, response decoding errors, and redirect-limit errors now propagate without marking a healthy server node unavailable.The async source remains the source of truth; the sync client was regenerated with
utils/run-unasync.py.Validation
pytest tests/api_call_test.py -q(33 passed)utils/run-unasync.py --checkgit diff --checkA full
pytest -qrun requires a local Typesense server and also encountered existing unrelated fixture failures in this environment.