Draft
Conversation
Collaborator
Author
|
The tests for the various numeral systems should probably be moved to Codex, and the test for deprecated symbol variants will always be annoying to maintain so I think it should be removed altogether. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As was previously discussed, this proposes to move numbering kinds to Codex. Numbering patterns stay in Typst, but numbering kinds and their "chars" are moved to Codex as numeral systems with shorthands.
This is still a draft as the corresponding Codex PR (typst/codex#145) should be merged first. Additionally, I made the decision to now raise an error when a numeral system cannot represent a number (e.g., zero) instead of arbitrarily falling back to Western Arabic numerals or a hyphen. Currently, the error is reported with a detached span, which is highly suboptimal.
For now, I do not make use of the names assigned to the various numeral systems in Codex and instead only use the shorthands. This means there should not be any observable behavior other than some numbers no longer being representable (hence the updated tests).