Fix WebSocket.send fast call compilation for Node.js v24+#1243
Closed
Fix WebSocket.send fast call compilation for Node.js v24+#1243
Conversation
…ol on Linux and LNK2019 on Windows for Node.js v25 (ABI 141) Co-authored-by: uNetworkingAB <110806833+uNetworkingAB@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Debug running issues introduced by 7c1272e
Fix undefined symbol for CFunctionInfo constructor in Node.js v25 (ABI 141)
Mar 14, 2026
…removed Co-authored-by: uNetworkingAB <110806833+uNetworkingAB@users.noreply.github.com>
Copilot
AI
changed the title
Fix undefined symbol for CFunctionInfo constructor in Node.js v25 (ABI 141)
Fix WebSocket.send fast call compilation for Node.js v24+
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V8 removed
FastApiTypedArray<T>andFastApiCallbackOptions::fallbackin Node.js v24, breaking compilation of theuWS_WebSocket_send_fastpath for ABI 137 (v24) and 141 (v25).Changes
src/WebSocketWrapper.h#include "node_version.h"(already present in the-I targets/node-VERSION/include/nodepath set bybuild.c)uWS_WebSocket_send_fastand itsCFunction::Makeregistration behind#if NODE_MODULE_VERSION <= 127(v22 and earlier retainFastApiTypedArray)FunctionTemplate::Newwithout the fast-call hintVersion mapping for reference:
NODE_MODULE_VERSION115 = v20, 127 = v22, 137 = v24, 141 = v25.📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.