[Do not merge] Ensure OnStart/OnStop hooks can only be called once#950
Open
sywhang wants to merge 1 commit intouber-go:masterfrom
Open
[Do not merge] Ensure OnStart/OnStop hooks can only be called once#950sywhang wants to merge 1 commit intouber-go:masterfrom
sywhang wants to merge 1 commit intouber-go:masterfrom
Conversation
…ber-go#931)" (uber-go#946)" This reverts commit 550fe46.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #950 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 30 30
Lines 1332 1337 +5
=======================================
+ Hits 1315 1320 +5
Misses 11 11
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same as #931.
Leaving this open for us to work on #945 and then merge.