Skip to content

feat(hook): Deliver events to integrations - #607

Merged
prathshenoy merged 1 commit into
mainfrom
prath.shenoy/hook-dispatch
Aug 24, 2026
Merged

feat(hook): Deliver events to integrations#607
prathshenoy merged 1 commit into
mainfrom
prath.shenoy/hook-dispatch

Conversation

@prathshenoy

@prathshenoy prathshenoy commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

What:

  • Consume lifecycle events from a durable queue and hand each one to the integrations it resolves to, running them concurrently and retrying then dead-lettering the ones that keep failing.
  • Record every dead-lettered event with its full payload and failure reason, and count it on a metric meant to page.

Why:

  • Keep a slow or broken integration from stalling or failing the work that triggered it.
  • Make a lost notification recoverable and impossible to miss, since nothing else in the system notices when one goes missing.

Test Plan

  • Add unit tests.

Revert Plan

  • Revert this PR. No service constructs the controller or subscribes to the hook topic.

Issues

@prathshenoy prathshenoy mentioned this pull request Aug 17, 2026
Merged
1 task
@prathshenoy
prathshenoy force-pushed the prath.shenoy/hook-event-contract branch from b5394eb to 837e0d8 Compare August 17, 2026 16:54
@prathshenoy
prathshenoy force-pushed the prath.shenoy/hook-dispatch branch from a09dcab to b6aef89 Compare August 17, 2026 16:56
@prathshenoy
prathshenoy marked this pull request as ready for review August 17, 2026 16:56
@prathshenoy
prathshenoy force-pushed the prath.shenoy/hook-event-contract branch from 837e0d8 to b5394eb Compare August 18, 2026 00:27
@prathshenoy
prathshenoy force-pushed the prath.shenoy/hook-dispatch branch from b6aef89 to a09dcab Compare August 18, 2026 00:27
@prathshenoy prathshenoy mentioned this pull request Aug 18, 2026
Merged
1 task
@behinddwalls

behinddwalls commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

🛑 Automatic stack rebase aborted — diff mismatch

The rebase of prath.shenoy/hook-dispatch completed without conflicts, but the resulting code diff does not match the original. This means the rebase silently altered code content. The branch was not force-pushed.

Please rebase manually and verify the changes are correct.

mnoah1
mnoah1 reviewed Aug 19, 2026
View reviewed changes
Comment thread platform/extension/hook/composite/hook.go Outdated
Comment thread platform/extension/hook/composite/hook.go Outdated
behinddwalls pushed a commit to behinddwalls/submitqueue that referenced this pull request Aug 19, 2026
@prathshenoy
feat(hook): Add contract for lifecycle events (uber#606)
4595135 
## Summary
**What**:
- Define the shared event format every domain publishes for
fire-and-forget lifecycle notifications, carrying origin, type, timing,
a staleness marker, and open per-event detail.
- Derive an event's identity from the transition it describes, so
replaying a transition produces the same identity and duplicate
deliveries collapse.

**Why**:
- Enable integrations to react to pipeline milestones without adding
call sites that can stall or fail a merge.
- Establish one schema and one identity rule before any producer ships,
so a consumer spanning several domains needs only one reader.

## Test Plan
- [x] Add unit tests.

## Revert Plan
- Revert this PR. No topic is registered and no message of this shape
exists on any queue.

## Issues
-
[CODEM-416](https://linear.app/uber/issue/CODEM-416/hooks-integration-downstream-notificaiton)

## Stack
1. @ uber#606
1. uber#607
1. uber#608
behinddwalls
behinddwalls reviewed Aug 19, 2026
View reviewed changes
Comment thread platform/extension/hook/hook.go Outdated
behinddwalls
behinddwalls reviewed Aug 19, 2026
View reviewed changes
Comment thread platform/extension/hook/hook.go
behinddwalls
behinddwalls reviewed Aug 19, 2026
View reviewed changes
Comment thread platform/extension/hook/composite/hook.go Outdated
behinddwalls
behinddwalls reviewed Aug 19, 2026
View reviewed changes
Comment thread platform/hook/dlq.go
@prathshenoy
prathshenoy force-pushed the prath.shenoy/hook-dispatch branch from a09dcab to 56a21ac Compare August 20, 2026 20:54
An error occurred while trying to automatically change base from prath.shenoy/hook-event-contract to main August 20, 2026 20:58
An error occurred while trying to automatically change base from prath.shenoy/hook-event-contract to main August 20, 2026 20:58
An error occurred while trying to automatically change base from prath.shenoy/hook-event-contract to main August 20, 2026 20:58
An error occurred while trying to automatically change base from prath.shenoy/hook-event-contract to main August 20, 2026 20:58
@prathshenoy
prathshenoy force-pushed the prath.shenoy/hook-dispatch branch from 56a21ac to 63b4e01 Compare August 20, 2026 20:59
@prathshenoy
prathshenoy deleted the branch main August 20, 2026 21:07
@prathshenoy prathshenoy reopened this Aug 20, 2026
@prathshenoy
prathshenoy changed the base branch from prath.shenoy/hook-event-contract to main August 20, 2026 21:36
@prathshenoy
prathshenoy marked this pull request as draft August 20, 2026 22:13
@prathshenoy
prathshenoy force-pushed the prath.shenoy/hook-dispatch branch from 63b4e01 to 8503587 Compare August 24, 2026 16:36
@prathshenoy
prathshenoy marked this pull request as ready for review August 24, 2026 16:53
@prathshenoy
prathshenoy force-pushed the prath.shenoy/hook-dispatch branch from 8503587 to 07e57cc Compare August 24, 2026 17:20
@prathshenoy
prathshenoy enabled auto-merge August 24, 2026 17:59
@prathshenoy prathshenoy mentioned this pull request Aug 24, 2026
Merged
1 task
mnoah1
mnoah1 approved these changes Aug 24, 2026
View reviewed changes
Comment thread platform/extension/hook/hook.go Outdated
@prathshenoy
prathshenoy force-pushed the prath.shenoy/hook-dispatch branch from 07e57cc to e297c9d Compare August 24, 2026 19:33
@prathshenoy
prathshenoy force-pushed the prath.shenoy/hook-dispatch branch from e297c9d to e08c06b Compare August 24, 2026 19:35
@prathshenoy
prathshenoy added this pull request to the merge queue Aug 24, 2026
Merged via the queue into main with commit fee08f1 Aug 24, 2026
15 checks passed
@behinddwalls
behinddwalls deleted the prath.shenoy/hook-dispatch branch August 24, 2026 20:00
behinddwalls pushed a commit to behinddwalls/submitqueue that referenced this pull request Sep 25, 2026
@prathshenoy
feat(orch): Consume hook events (uber#608)
ac94e24 
## Summary
**What**:
- Register the orchestrator's hook stage, so lifecycle events are
consumed from the queue and handed to the integrations each event
resolves to. No integration is wired yet, so events are accepted and
discarded.
- Register the matching dead-letter stage, so an event that fails every
retry is recorded and alerted on instead of accumulating unread.

**Why**:
- Prove the delivery path end to end before anything produces an event,
so a later change adds producers to a route that already works.
- Keep a deployment with no integrations configured distinguishable from
one that is silently losing events.

## Test Plan
- [x] Add unit tests.

## Revert Plan
- Revert this PR. Since nothing publishes hook events yet and the
resolver returns only a no-op hook, no side effect is lost.

## Issues
-
[CODEM-416](https://linear.app/uber/issue/CODEM-416/hooks-integration-downstream-notificaiton)

## Stack
1. uber#607
1. @ uber#608
1. uber#632
behinddwalls pushed a commit to behinddwalls/submitqueue that referenced this pull request Sep 25, 2026
@prathshenoy
feat(stovepipe): Consume hook events (uber#632)
c93310d 
## Summary
**What**:
- Register the hook stage and its dead-letter stage in Stovepipe's
consumer wiring, on a topic named for the domain, with a resolver that
hands every event to the no-op hook.

**Why**:
- Wire the stage in a second domain, so attaching a real integration to
Stovepipe is a resolver swap rather than new plumbing, and two domains
on one queue backend keep their own hook topics.

## Test Plan
- [x] Add unit tests.

## Revert Plan
- Revert this PR. Nothing publishes hook events yet and the resolver
returns only a no-op hook.

## Issues
-
[CODEM-416](https://linear.app/uber/issue/CODEM-416/hooks-integration-downstream-notificaiton)

## Stack
1. uber#607
1. uber#608
1. @ uber#632

This branch was previously deployed

1 inactive deployment
stack-rebase — e08c06bf Deployed Aug 24, 2026 by prathshenoy via Rebase Stack #440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnoah1 mnoah1 mnoah1 approved these changes
@sbalabanov sbalabanov Awaiting requested review from sbalabanov sbalabanov is a code owner
@behinddwalls behinddwalls Awaiting requested review from behinddwalls behinddwalls is a code owner

Assignees

No one assigned

Labels

AutoMerge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prathshenoy @behinddwalls @mnoah1