docs(stovepipe): propose request log - #633
Merged
Merged
Conversation
mnoah1
marked this pull request as ready for review
August 26, 2026 17:25
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
August 26, 2026 17:25
mnoah1
force-pushed
the
mnoah1/stovepipe-event-history
branch
from
August 26, 2026 17:36
94e64c4 to
002c846
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-event-history
branch
from
August 31, 2026 16:28
002c846 to
0f9d91d
Compare
mnoah1
changed the title
mnoah1
force-pushed
the
mnoah1/stovepipe-event-history
branch
2 times, most recently
from
August 31, 2026 22:38
cbb09ff to
18539df
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-event-history
branch
from
August 31, 2026 22:52
18539df to
8626bfc
Compare
behinddwalls
approved these changes
Sep 1, 2026
behinddwalls
pushed a commit
to behinddwalls/submitqueue
that referenced
this pull request
Sep 25, 2026
## Summary Intent: - Expose the retained Stovepipe request log as public request history using SubmitQueue-aligned API terminology and response shapes. - Keep current-state reads owned by operational entities instead of introducing a competing materialized projection. Changes: - Return ordered `HistoryEvent` values directly from request-ID lookup. - Return repeated `RequestHistory` values from URI lookup; each contains only the request ID and ordered events, while the current mapping yields one and the contract can represent future retained attempts. - Resolve URI, build strategy, and base URI from the Request instead of duplicating them in history responses. - Define the direct projection from stored `RequestLog` records and explain why Stovepipe does not need SubmitQueue separate history materialization. - Keep the raw request-log metadata map and validation degree out of the initial public API; a typed projection can be added when metadata readers and enforcement land. This PR builds on the request-log RFC in uber#633. ## Test Plan - `./tool/bazel test //api/stovepipe/... //service/stovepipe/... //stovepipe/...` - `make lint check-tidy check-gazelle` ## Revert Plan Revert this documentation-only PR; uber#633 remains independently reviewable. ## Jira Issues None.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intent:
Changes:
RequestLogentity, state and event vocabularies, stable identities, and queue-scoped storage contract.Test Plan
./tool/bazel test //api/stovepipe/... //service/stovepipe/... //stovepipe/...make lint check-tidy check-gazelleRevert Plan
Revert this documentation-only PR.
Jira Issues
None.