feat(stovepipe): add request history protobuf contract - #638
Merged
mnoah1 merged 1 commit intoSep 1, 2026
Merged
Conversation
mnoah1
force-pushed
the
mnoah1/stovepipe-request-history-proto
branch
from
August 27, 2026 15:14
981f4f1 to
348b7e3
Compare
mnoah1
changed the base branch from
mnoah1/stovepipe-get-validation-api
to
mnoah1/stovepipe-history-api
August 27, 2026 15:14
mnoah1
marked this pull request as ready for review
August 27, 2026 15:18
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
August 27, 2026 15:18
mnoah1
force-pushed
the
mnoah1/stovepipe-request-history-proto
branch
from
August 31, 2026 16:28
348b7e3 to
73724a8
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-request-history-proto
branch
2 times, most recently
from
August 31, 2026 17:19
787296a to
1b083b2
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-request-history-proto
branch
from
August 31, 2026 22:21
1b083b2 to
c66766b
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-request-history-proto
branch
2 times, most recently
from
August 31, 2026 22:52
580169a to
cd9c689
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-request-history-proto
branch
from
August 31, 2026 23:03
cd9c689 to
9d86a83
Compare
behinddwalls
approved these changes
Sep 1, 2026
behinddwalls
pushed a commit
to behinddwalls/submitqueue
that referenced
this pull request
Sep 25, 2026
## Summary Intent: - Persist immutable request states and explanatory lifecycle occurrences in the internal Stovepipe request log. - Keep storage terminology and metadata handling aligned with SubmitQueue while supporting the public history API from uber#638. Changes: - Add an append-only MySQL `request_log` table with stable occurrence identity. - Keep core lifecycle values in columns and store occurrence-specific context in a non-null JSON metadata column. - Require writers to supply every non-null column value; the table defines no value defaults. - Remove dedicated superseding-request, build-ID, and fact-degree columns. - Index records for bounded, complete per-request reads. - Include request-log data in integration database cleanup. ## Test Plan - Loaded all Stovepipe schemas into an isolated MySQL 8 database. - Inserted representative request-log records and exercised chronological retrieval. - `./tool/bazel test //stovepipe/extension/storage/mysql/...` - `make lint check-tidy check-gazelle` ## Revert Plan Revert this PR and remove the unused table before deploying code that writes request-log records. ## Jira Issues None.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intent:
Changes:
HistoryEventvalues directly from request-ID lookup.RequestHistoryvalues from URI lookup; each contains onlyrequest_idand orderedevents.ValidationResultprojection.This PR builds directly on #634.
Test Plan
./tool/bazel test //api/stovepipe/... //service/stovepipe/... //stovepipe/...make lintmake check-tidymake check-gazelleRevert Plan
Revert this PR; the request-history RFC remains independently reviewable in #634.
Jira Issues
None.