Skip to content

fix(runway): ISS-014 use portable DLQ failures - #679

Merged
sbalabanov merged 1 commit into
mainfrom
sergeyb/fix-iss-014-portable-dlq-failure
Sep 16, 2026
Merged

sbalabanov merged 1 commit into
mainfrom
sergeyb/fix-iss-014-portable-dlq-failure

Conversation

@sbalabanov

@sbalabanov sbalabanov commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Intent:

  • Preserve backend-independent dead-letter failure reasons in Runway responses.
  • Keep legacy metadata and the existing generic reason as compatibility fallbacks.

Changes:

  • Prefer consumer.Delivery.Failure() when constructing a terminal merge result.
  • Add table-driven coverage for portable failures, legacy metadata, default reasons, and published result identity.

Reproduction:

  • A non-MySQL queue backend dead-letters a merge request with Delivery.Failure() set to the provider error but without dlq.last_error metadata.
  • Runway previously returned the generic failure reason; it now publishes the actual recorded failure to the client.

Generated by the 🪄 pr-create skill in devexp-agent-marketplace

Test Plan

Issues

T3-ISS-014

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sbalabanov
sbalabanov marked this pull request as ready for review September 8, 2026 22:55
@sbalabanov
sbalabanov requested review from a team and behinddwalls as code owners September 8, 2026 22:55
Summary:
Intent:
- Preserve backend-independent dead-letter failure reasons in Runway responses.
- Keep legacy metadata and the existing generic reason as compatibility fallbacks.

Changes:
- Prefer consumer.Delivery.Failure() when constructing a terminal merge result.
- Add table-driven coverage for portable failures, legacy metadata, default reasons, and published result identity.

Reproduction:
- A non-MySQL queue backend dead-letters a merge request with Delivery.Failure() set to the provider error but without dlq.last_error metadata.
- Runway previously returned the generic failure reason; it now publishes the actual recorded failure to the client.

---

<sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
@sbalabanov
sbalabanov force-pushed the sergeyb/fix-iss-014-portable-dlq-failure branch from f8d946c to e5e244c Compare September 16, 2026 16:06
@sbalabanov
sbalabanov added this pull request to the merge queue Sep 16, 2026
@sbalabanov
sbalabanov removed this pull request from the merge queue due to a manual request Sep 16, 2026
@sbalabanov
sbalabanov merged commit 980e921 into main Sep 16, 2026
16 of 17 checks passed
@behinddwalls
behinddwalls deleted the sergeyb/fix-iss-014-portable-dlq-failure branch September 16, 2026 16:14

This branch was successfully deployed

1 active deployment
stack-rebase — e5e244cb Deployed Sep 16, 2026 by sbalabanov via Rebase Stack #508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants