fix(runway): ISS-014 use portable DLQ failures - #679
Merged
Merged
Conversation
|
|
sbalabanov
marked this pull request as ready for review
September 8, 2026 22:55
behinddwalls
approved these changes
Sep 14, 2026
Summary: Intent: - Preserve backend-independent dead-letter failure reasons in Runway responses. - Keep legacy metadata and the existing generic reason as compatibility fallbacks. Changes: - Prefer consumer.Delivery.Failure() when constructing a terminal merge result. - Add table-driven coverage for portable failures, legacy metadata, default reasons, and published result identity. Reproduction: - A non-MySQL queue backend dead-letters a merge request with Delivery.Failure() set to the provider error but without dlq.last_error metadata. - Runway previously returned the generic failure reason; it now publishes the actual recorded failure to the client. --- <sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
sbalabanov
force-pushed
the
sergeyb/fix-iss-014-portable-dlq-failure
branch
from
September 16, 2026 16:06
f8d946c to
e5e244c
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intent:
Changes:
Reproduction:
Generated by the 🪄 pr-create skill in devexp-agent-marketplace
Test Plan
Issues
T3-ISS-014