feat(stovepipe): Persist terminal build identity - #746
Draft
prathshenoy wants to merge 1 commit into
Draft
prathshenoy wants to merge 1 commit into
prathshenoy wants to merge 1 commit into
Conversation
prathshenoy
force-pushed
the
prath.shenoy/stovepipe-project-result-build
branch
3 times, most recently
from
September 25, 2026 03:19
208831a to
66cef3f
Compare
prathshenoy
changed the title
prathshenoy
force-pushed
the
prath.shenoy/stovepipe-project-result-build
branch
5 times, most recently
from
September 25, 2026 14:59
0236e2b to
8aa2492
Compare
Summary: Persist the winning terminal build identity in the terminal request-history entry, atomically with the request outcome, so record can later resolve final artifacts without a Build reverse index. Test Plan: ./tool/bazel test //stovepipe/controller/buildsignal:go_default_test //stovepipe/core/messagequeue:go_default_test //stovepipe/extension/storage/mysql:go_default_test --test_output=errors Revert Plan: Revert this commit to stop persisting terminal build identity. Jira Issues: None
prathshenoy
force-pushed
the
prath.shenoy/stovepipe-project-result-build
branch
from
September 25, 2026 15:01
8aa2492 to
a51f9d4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Persist the winning terminal build identity in the terminal request-history entry, atomically with the request outcome, so record can later resolve final artifacts without a Build reverse index.
Test Plan
./tool/bazel test //stovepipe/controller/buildsignal:go_default_test //stovepipe/core/messagequeue:go_default_test //stovepipe/extension/storage/mysql:go_default_test --test_output=errors
Revert Plan
Revert this commit to stop persisting terminal build identity.
Issues