Repository navigation
feat(submitqueue): request projection cleanup - get requests list by timestamp and then get request_summary rows - #800
Merged
Conversation
mnoah1
added this pull request to stack #803
October 7, 2026 17:35
mnoah1
changed the title
mnoah1
changed the title
mnoah1
changed the title
mnoah1
changed the title
mnoah1
marked this pull request as ready for review
October 7, 2026 17:58
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 7, 2026 17:58
mnoah1
added a commit
that referenced
this pull request
Oct 7, 2026
Summary: Intent: - Complete the receipt-based List migration from #800: keep one authoritative request summary and immutable lookup keys. Changes: - Remove queue-summary writes, the duplicate entity/store, and obsolete tests and mocks. - Idempotently ensure URI mappings before the receipt key, including partial-write retries and stale logs. - Update rollout docs; retain the legacy SQL definition for deployment compatibility. Test Plan: - Deploy after #800 is stable. Rollback must retain the receipt-based reader once duplicate writes stop. - Retire the table in a separate internal schema change after old binaries and the rollback window are gone. UQL DEPRECATED can drop immediately in Vitess; no physical retirement is enabled here. --- <sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
mnoah1
force-pushed
the
mnoah1/submitqueue-list-read-cutover
branch
from
October 7, 2026 17:58
ec3187f to
8f30300
Compare
mnoah1
added a commit
that referenced
this pull request
Oct 7, 2026
Summary: Intent: - Complete the receipt-based List migration from #800: keep one authoritative request summary and immutable lookup keys. Changes: - Remove queue-summary writes, the duplicate entity/store, and obsolete tests and mocks. - Idempotently ensure URI mappings before the receipt key, including partial-write retries and stale logs. - Update rollout docs; retain the legacy SQL definition for deployment compatibility. Test Plan: - Deploy after #800 is stable. Rollback must retain the receipt-based reader once duplicate writes stop. - Retire the table in a separate internal schema change after old binaries and the rollback window are gone. UQL DEPRECATED can drop immediately in Vitess; no physical retirement is enabled here. --- <sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
mnoah1
force-pushed
the
mnoah1/submitqueue-list-read-cutover
branch
from
October 7, 2026 18:05
8f30300 to
a91ce72
Compare
Summary: Builds on #799 to serve List from immutable request_receipt keys and authoritative request_summary rows, instead of the duplicated queue-summary projection. - Scan receipt keys, then point-read summaries for visible results; keep bounds, string-ID ordering, and page-token format unchanged. - Use the existing RequestSummary response type and wire mapper. - Fail the page on missing, mismatched, or hidden summaries using the existing InternalConsistencyError. - Add controller and gateway integration coverage; update the RFC. Keep legacy projection writes for rollback. Deploy only after #799 reaches all writers. No backfill or legacy-read fallback: requests without receipt keys are absent from List. Duplicate-write and old-table removal remain follow-up work. None — no tracking issue was supplied. Test Plan: After CD rollout, confirm new Land requests appear in List with the same summary fields as ID lookup, check continuation pages, and monitor page latency. Revert Plan: Revert the read cutover to restore the old List path. Legacy projection writes remain active; this PR makes no schema changes. API Changes: No RPC/proto changes. The Go ListResult now contains RequestSummary values.
mnoah1
added a commit
that referenced
this pull request
Oct 7, 2026
Summary: Intent: - Complete the receipt-based List migration from #800: keep one authoritative request summary and immutable lookup keys. Changes: - Remove queue-summary writes, the duplicate entity/store, and obsolete tests and mocks. - Idempotently ensure URI mappings before the receipt key, including partial-write retries and stale logs. - Update rollout docs; retain the legacy SQL definition for deployment compatibility. Test Plan: - Deploy after #800 is stable. Rollback must retain the receipt-based reader once duplicate writes stop. - Retire the table in a separate internal schema change after old binaries and the rollback window are gone. UQL DEPRECATED can drop immediately in Vitess; no physical retirement is enabled here. --- <sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
mnoah1
force-pushed
the
mnoah1/submitqueue-list-read-cutover
branch
from
October 7, 2026 19:46
a91ce72 to
981c311
Compare
Tmwakalasya
pushed a commit
to Tmwakalasya/submitqueue
that referenced
this pull request
Oct 7, 2026
…sed lookup table (uber#799) ## Summary First step toward keeping one full request projection in request_summary, with a small time-based lookup instead of duplicating lifecycle data for List. All required response data and receipt time are already captured. ### Changes - Add request_receipt with only (queue, received_at_ms, request_id), its immutable storage contract, and gateway wiring. - Ensure receipt keys after public projection writes, including unchanged/stale-log retries. Keep accepting receipts hidden and surface partial-write failures for existing retry handling. - Keep List reads and the existing queue-summary projection writes in place for a safe cutover. - Add storage, materializer, and integration coverage. ### Migration plan #### Rollout from this PR (CD) CD deploys the additive request_receipt table and gateway receipt-store/materializer changes, with the table available before receipt writes begin. Public request projections populate receipt keys alongside the existing queue-summary projection. List reads remain unchanged. #### Next 1. Next PR will switch List to scan receipt keys and point-read request_summary. Preserve the API, time bounds, ordering, and page tokens; check page latency and retain old projection writes during the rollback window. 2. Once cutover is stable, land last PR in the stack: stop duplicate projection writes, remove RequestQueueSummary and its store/mapper, and retire request_summary_by_queue after the rollback window. ## Test Plan After rollout, confirm newly public requests have matching receipt keys while List continues using the existing projection. ## Revert Plan Revert the writer rollout; List still uses the existing projection. Leave the additive table in place until no writers depend on it. ## API Changes No RPC/proto changes. Gateway storage implementations must provide the new RequestReceiptStore accessor. ## Issue Links LINEAR-CODEM-561 — https://linear.app/uber/issue/CODEM-561/clean-up-duplicate-request-projection-in-submitqueue-code ## Stack 1. @ uber#799 1. uber#800 1. uber#801
behinddwalls
approved these changes
Oct 8, 2026
behinddwalls
pushed a commit
that referenced
this pull request
Oct 8, 2026
Summary: Intent: - Complete the receipt-based List migration from #800: keep one authoritative request summary and immutable lookup keys. Changes: - Remove queue-summary writes, the duplicate entity/store, and obsolete tests and mocks. - Idempotently ensure URI mappings before the receipt key, including partial-write retries and stale logs. - Update rollout docs; retain the legacy SQL definition for deployment compatibility. Test Plan: - Deploy after #800 is stable. Rollback must retain the receipt-based reader once duplicate writes stop. - Retire the table in a separate internal schema change after old binaries and the rollback window are gone. UQL DEPRECATED can drop immediately in Vitess; no physical retirement is enabled here. --- <sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on #799 to serve List from immutable request_receipt keys and authoritative request_summary rows, instead of the duplicated queue-summary projection.
Changes
Rollout
Deploy only after #799 reaches all writers. No backfill or legacy-read fallback: requests without receipt keys are absent from List. Duplicate-write and old-table removal remain follow-up work.
Test Plan
After CD rollout, confirm new Land requests appear in List with the same summary fields as ID lookup, check continuation pages, and monitor page latency.
Revert Plan
Revert the read cutover to restore the old List path. Legacy projection writes remain active; this PR makes no schema changes.
API Changes
No RPC/proto changes. The Go ListResult now contains RequestSummary values.
Issue Links
None — no separate ticket supplied for this stacked follow-up.
Stack