fix(itg): preserve dependency edges when re-synthesizing external rule targets - #315
Merged
Merged
Conversation
…e targets UpdateGraph re-synthesizes a targethasher.Target for each external rule target already present in the optimized graph but absent from the current query result (i.e. carried over unchanged). That reconstruction previously left Deps unset, so upsertTarget treated the target as having zero dependencies and dropped its existing dependency edges on every update where the target wasn't freshly re-queried. This silently broke reverse-dep invalidation for anything depending on that external target transitively. Rebuild Deps from the target's recorded dependency IDs via TargetIDToString so the edges survive being carried over. Co-Authored-By: Claude Sonnet 5 <ANONYMIZED_EMAIL_ADDRESS_0_6>
xytan0056
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UpdateGraph re-synthesizes a targethasher.Target for each external rule target already present in the optimized graph but absent from the current query result (i.e. carried over unchanged). That reconstruction previously left Deps unset, so upsertTarget treated the target as having zero dependencies and dropped its existing dependency edges on every update where the target wasn't freshly re-queried. This silently broke reverse-dep invalidation for anything depending on that external target transitively.
Rebuild Deps from the target's recorded dependency IDs via TargetIDToString so the edges survive being carried over.
Test Plan
Unit test and internal testing