Route both sequence comparators through the hybrid index - #77
Merged
drametwally merged 1 commit intoSep 21, 2026
Merged
Conversation
The hybrid was searched with ngld alone, so gld reached it only through the pairing matrix, which asserts self-retrieval rather than recall. The test now runs both. The minimum similarity it searches at is taken from the scan rather than fixed, since gld is not normalized and one fixed number admits every row for one comparator and none for the other.
drametwally
deleted the
cover-the-hybrid-with-both-sequence-comparators
branch
September 21, 2026 01:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while re-deriving the search-test coverage matrix from the tree.
The hybrid structure was searched with
ngldalone, sogldreached it only throughIndexPairingMatrixTest. That test asserts a row is found by its own record and that whatevercomes back carries the scan's similarity, but not that a merely similar row is found. The
hybrid prunes on the minimum similarity when it routes between its two halves, which is
exactly where the two sequence comparators differ, so
ngldalone did not cover it.theHybridStructureRoutesSequencesByTermCountnow runs both comparators.Parameterising it failed immediately on
gld, which is the point:gldis not normalised, sothe fixed 0.8 minimum similarity that suited
ngldadmitted nothing at all. The threshold isnow taken from the brute-force scan, as the third highest similarity it finds, which is
comparator-agnostic and keeps the minimum-similarity routing path under test.
662 tests pass.