Fix daisy and CI
#5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyask
force-pushed
the
skia/fix_ci_free_disk_space
branch
from
64a7b03 to
bb16f03
Compare
Hyask
force-pushed
the
skia/fix_ci_free_disk_space
branch
from
bb16f03 to
f7c4e9b
Compare
This defers the creation of the app to the time of function call, and not at import time anymore. This eases the configuration of many things through the `local_config.py` mechanism, that works at import time.
Hyask
force-pushed
the
skia/fix_ci_free_disk_space
branch
from
f7c4e9b to
bdbdc5e
Compare
Hyask
changed the title
daisy and CI
Collaborator
Author
|
CI is still red, but is in a way better shape than before and remaining lint issues are expected. Charm issue might actually be transient, so let's see if it passes in the merge commit run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See each commit for description.