CMakeLists.txt: fix LIB_SEARCH_PATH on apple silicon - #458
Open
willjones9 wants to merge 1 commit into
Open
willjones9 wants to merge 1 commit into
willjones9 wants to merge 1 commit into
Conversation
`CMAKE_INSTALL_PREFIX` on Apple Silicon should be set to `/opt/homebrew`, not `/usr/local` Before: ``` $ ucode -e "import * as fs from 'fs';" Syntax error: Unable to resolve path for module 'fs' In line 1, byte 25: `import * as fs from 'fs';` Near here --------------^ ``` After: ``` $ ucode -e "import * as fs from 'fs';" $ echo $? 0 ``` Signed-off-by: Will Jones <willjones_9@icloud.com>
Collaborator
|
Is /opt/homebrew an official Apple thing now? I thought it is a 3rd party package manager for MacOS? |
Author
|
It's not an official Apple thing, no, however Part of the build process already takes this into consideration, but that happens after |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMAKE_INSTALL_PREFIXon Apple Silicon should be set to/opt/homebrew, not/usr/localBefore:
After: