Skip to content

fix: accept encrypted PKCS#12 safe contents - #70

Merged
Baskerville42 merged 3 commits into
mainfrom
codex/fix-pkcs12-encrypted-safe
Oct 22, 2026
Merged

Baskerville42 merged 3 commits into
mainfrom
codex/fix-pkcs12-encrypted-safe

Conversation

@Baskerville42

Copy link
Copy Markdown
Contributor

Summary

  • accept encrypted PKCS#12 certificate safe contents and private-key bags
  • support allow-listed SHA-1/3DES PBE and PBES2/PBKDF2 with AES-CBC
  • bound KDF iterations and reject unsupported parameters fail-closed
  • add production-shaped end-to-end profile signing coverage
  • update patched test/documentation dependencies required by the audit gate

Verification

  • npm ci --ignore-scripts --no-audit --no-fund
  • npm run verify
  • npm audit --audit-level=high
  • npm audit signatures

@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.33333% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/certificates/signing-material.ts 93.33% 0 Missing and 5 partials ⚠️

📢 Thoughts on this report? Let us know!

nastyabon8
nastyabon8 previously approved these changes Oct 22, 2026
@Baskerville42
Baskerville42 force-pushed the codex/fix-pkcs12-encrypted-safe branch from 87fdfae to f349410 Compare October 22, 2026 18:54
@Baskerville42
Baskerville42 merged commit ec6f634 into main Oct 22, 2026
12 of 13 checks passed
@Baskerville42
Baskerville42 deleted the codex/fix-pkcs12-encrypted-safe branch October 22, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants