Skip to content

Rename File.exists? to File.exist? for ruby 3.2#2

Open
Largo wants to merge 5 commits intoukoloff:masterfrom
Largo:patch-1
Open

Rename File.exists? to File.exist? for ruby 3.2#2
Largo wants to merge 5 commits intoukoloff:masterfrom
Largo:patch-1

Conversation

@Largo
Copy link
Copy Markdown

@Largo Largo commented Jan 11, 2023

This function got removed in ruby 3.2. I prefered the exists syntax as well, but the gem is broken now like this.

This function got removed in ruby 3.2. I prefered the exists syntax as well, but the gem is broken now like this.
@ukoloff
Copy link
Copy Markdown
Owner

ukoloff commented Jan 13, 2023

It looks like you're right, but I cannot test it, since I'm out of sync with Ruby world for a long time.

Even if I accept your PR, it is unlikely that I be able to rebuild and publish a new version of the gem.

Maybe you (or someone else) could take over this project, if it is still usable for someone / something?

@Largo
Copy link
Copy Markdown
Author

Largo commented Jan 13, 2023

I think it's still important, since the use case is still there. Considering the amount of downloads, there must be other users out there. I can release a new version. This is my rubygems profile. I'm not exactly sure if you can just hand it over like this, or if you have to use the new adoptions process. Thank you in advance!

@ukoloff
Copy link
Copy Markdown
Owner

ukoloff commented Jan 13, 2023

Well, you should now get mail from RubyGems, confirm et voila! - you are the owner of the openssl-win-root gem! :-)

@Largo
Copy link
Copy Markdown
Author

Largo commented Jan 13, 2023

Thank you! I pushed the new version to rubygems. I haven't changed the git repo link on there yet, especially because it is only a small change. Shall we leave it for now and you accept the merge request?

Copy link
Copy Markdown

@emwhipple30-svg emwhipple30-svg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants