Repository navigation
Accept normalized CLA signature comments - #35
Conversation
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
LGTM. The workflow now triggers the CLA action for signature comments containing surrounding Markdown or trailing whitespace, while the action remains responsible for validating an exact normalized signature line. The recheck command remains exact, and no repository-local correctness or security regression is evident.
|
🎉 PR #35 has been merged—thank you, @glenn-jocher!
This focused workflow improvement lets CLA comments with surrounding Markdown or trailing whitespace reach the existing normalized signature matcher, while keeping |
Valid CLA signature comments with trailing whitespace or surrounding Markdown currently never reach the normalized action matcher because the workflow gate requires exact equality.
This makes only the signature gate permissive. The
recheckcommand remains exact, and the action still decides whether a single normalized line is a valid signature, so quoted or instructional text does not sign the CLA.Related matcher fix: ultralytics/actions#894
Validation:
actionlint .github/workflows/cla.ymlnpx prettier@3.8.5 --check .github/workflows/cla.yml🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Updated the CLA workflow gate to pass comments containing the normalized signature phrase to the existing matcher, allowing trailing whitespace or surrounding Markdown to be handled.
📊 Key Changes
contains()check in.github/workflows/cla.yml.recheckcommand matching exact.🎯 Purpose & Impact