Conversation
benmelz
commented
Apr 3, 2026
Comment on lines
-10
to
-11
| set :app_env, fetch(:stage) | ||
| set :default_env, { APP_ENV: fetch(:app_env) } |
Member
Author
There was a problem hiding this comment.
I get what's going on here, but conversely I'm not sure where exactly RACK_ENV=production happens in the other apps...
Member
There was a problem hiding this comment.
I think the other apps are either a) Rails apps where capistrano/rails takes care of it, or b) apps where the "environment" doesn't matter for anything done during deployment. I think the reason for this setting was to allow us to run rake tasks (compile assets) with only production gems available, given that the Rakefile conditionally refers to RSpec, Rubocop, etc.
werebus
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in the other sinatra apps - precursor to credentials