Skip to content

Add a step to build base image locally #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashmanda-cs merged 12 commits into from
Aug 18, 2026
Merged

Add a step to build base image locally #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3b658c9
Add a step to build base image locally
ashmanda-cs Aug 12, 2026
0332800
Specify pom.xml in Maven build command
ashmanda-cs Aug 12, 2026
c3ddcba
Update comment formatting in CI workflow file
ashmanda-cs Aug 12, 2026
b326bf4
Add local base image build step to workflow
ashmanda-cs Aug 12, 2026
231f1c9
Modify base image handling in integration tests workflow
ashmanda-cs Aug 12, 2026
db52f05
Modify workflow to fetch or build base image
ashmanda-cs Aug 12, 2026
e7c5788
Modify container integration test workflow for base image
ashmanda-cs Aug 12, 2026
1e00d2d
Fix comments and improve BASE_IMAGE evaluation
ashmanda-cs Aug 12, 2026
8b91a92
Update container_integration_tests.yml
ashmanda-cs Aug 12, 2026
493f9ff
Improve base image fetching logic in CI workflow
ashmanda-cs Aug 12, 2026
a63a825
Refactor base image fetching and building logic
ashmanda-cs Aug 12, 2026
01fefd9
Refactor base image fetching logic in workflow
ashmanda-cs Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion .github/workflows/container_integration_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,26 @@ jobs:
run: |
set -euo pipefail
mvn -version

# ---------------------------
# FETCH OR BUILD BASE IMAGE
# ---------------------------
- name: Fetch or Build local base image
run: |
set -euo pipefail

# 1. Ask Maven for the expected tag
BASE_IMAGE=$(cd modules/container-base && mvn build-helper:parse-version help:evaluate -Dexpression=base.image -q -DforceStdout -Pct)
echo "Target base image: $BASE_IMAGE"

# 2. Try to pull it. If that fails, build it.
if docker pull "$BASE_IMAGE"; then
echo "✅ Image found and pulled successfully! Skipping local build."
else
echo "⚠️ Pull failed (image likely doesn't exist yet). Building locally..."
mvn -Pct clean package -f modules/container-base/pom.xml
fi

# ---------------------------
# BUILD IMAGES (Dataverse-native)
# ---------------------------
Expand Down Expand Up @@ -282,4 +301,4 @@ jobs:
with:
name: docker-logs
path: docker-logs/
retention-days: 14
retention-days: 14
19 changes: 19 additions & 0 deletions .github/workflows/dataverse_jsf_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,25 @@ jobs:
set -euo pipefail
mvn -version

# ---------------------------
# FETCH OR BUILD BASE IMAGE
# ---------------------------
- name: Fetch or Build local base image
run: |
set -euo pipefail

# 1. Ask Maven for the expected tag
BASE_IMAGE=$(cd modules/container-base && mvn build-helper:parse-version help:evaluate -Dexpression=base.image -q -DforceStdout -Pct)
echo "Target base image: $BASE_IMAGE"

# 2. Try to pull it. If that fails, build it.
if docker pull "$BASE_IMAGE"; then
echo "✅ Image found and pulled successfully! Skipping local build."
else
echo "⚠️ Pull failed (image likely doesn't exist yet). Building locally..."
mvn -Pct clean package -f modules/container-base/pom.xml
fi

# ---------------------------
# BUILD IMAGES (Dataverse-native)
# ---------------------------
Expand Down
Loading