Skip to content

fix(docker): tolerate unavailable IPv6 loopback #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nightcityblade wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

fix(docker): tolerate unavailable IPv6 loopback #2081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deploy/docker/supervisord.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ logfile_maxbytes=0
[program:redis]
; Loopback-only and password-protected. REDIS_PASSWORD is exported by
; entrypoint.sh from the mounted secret; the app must supply it to connect.
command=/usr/bin/redis-server --loglevel notice --bind 127.0.0.1 ::1 --requirepass "%(ENV_REDIS_PASSWORD)s" --dir /var/lib/redis
command=/usr/bin/redis-server --loglevel notice --bind 127.0.0.1 -::1 --requirepass "%(ENV_REDIS_PASSWORD)s" --dir /var/lib/redis
user=appuser ; Run redis as our non-root user
autorestart=true
priority=10
Expand All @@ -31,4 +31,4 @@ stdout_logfile_maxbytes=0
stderr_logfile=/dev/stderr ; Redirect gunicorn stderr to container stderr
stderr_logfile_maxbytes=0

# Optional: Add filebeat or other logging agents here if needed
# Optional: Add filebeat or other logging agents here if needed
4 changes: 2 additions & 2 deletions deploy/docker/tests/test_security_container_posture.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ class TestSupervisord:
def test_redis_requires_password(self, supervisord):
assert "--requirepass" in supervisord

def test_redis_bound_loopback(self, supervisord):
assert "--bind 127.0.0.1" in supervisord
def test_redis_bound_loopback_with_optional_ipv6(self, supervisord):
assert "--bind 127.0.0.1 -::1" in supervisord

def test_gunicorn_bind_is_env_driven(self, supervisord):
# entrypoint.sh resolves GUNICORN_BIND (loopback unless a credential).
Expand Down
Loading