Enhancement/96-Improve-View-Functionality-For-Room#104
Open
PIPetkova19 wants to merge 4 commits into
Open
Conversation
PIPetkova19
changed the title
Manastirski
requested changes
Jul 24, 2026
| facultyId: room.facultyId, | ||
| roomNumber: room.roomNumber, | ||
| categoryId: room.categoryId, | ||
| position: index + 1, |
Contributor
There was a problem hiding this comment.
position is not in room-elm.ts,
| @@ -0,0 +1,5 @@ | |||
| export interface CategoryElm { | |||
Contributor
There was a problem hiding this comment.
apply the naming convention
| id: category.id, | ||
| roomType: category.roomType, | ||
| capacity: category.capacity, | ||
| position: index + 1, |
Contributor
There was a problem hiding this comment.
position is not in category-elm.ts
| id: string; | ||
| facultyId: string; | ||
| roomNumber: string; | ||
| roomNumber: string, |
Contributor
There was a problem hiding this comment.
" ; " instead of " , "
| startWith(void 0), | ||
| switchMap(() => this.roomService.getRooms()) | ||
| ); | ||
| data$ = this.roomService.getRooms(); |
Contributor
There was a problem hiding this comment.
Dropping the refreshNeeded step from the data$ pipeline will cause a problem, since RoomAddForm still calls refreshNeeded.next() after creating a room, the table wont pick up new rooms until a manual refresh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made: