Facade migration t3/ migrate lector to facade pattern#124
Open
DrDeathDrop wants to merge 9 commits into
Open
Conversation
added 2 commits
June 30, 2026 13:39
…d added tests for that as well
constantine0621
requested changes
Jun 30, 2026
constantine0621
left a comment
constantine0621
left a comment
Contributor
There was a problem hiding this comment.
changes needed in the Mapper and faculty checks in the WebFacade, recommended to add a LectorValidator for the faculty checks
DjesikaV
reviewed
Jul 1, 2026
…ewritten validator tests
https://github.com/uni-dev-lab/uniplan into Facade-migration-T3/-Migrate-lector-to-facade-pattern
constantine0621
approved these changes
Jul 2, 2026
Manastirski
requested changes
Jul 24, 2026
| public ResponseEntity<Void> deleteLector(@NotNull @PathVariable UUID id) { | ||
| lectorService.deleteLector(id); | ||
|
|
||
| public ResponseEntity<Void> deleteLector(@NotNull @PathVariable final UUID id) { |
Comment on lines
+55
to
+56
| lectorMapper.updateEntity(request, lector); | ||
| lectorValidator.validate(request); |
Contributor
There was a problem hiding this comment.
wrong order, the validation should be first than the updateEntity()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.